feat(cmd/gno): add support for gno.mod projects in gno doc #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would seem like tests are failing because they can't reach test3? Should we change gno mod tests to not use the network? Shall I open an issue for that? |
Please. I was thinking about that for a long time. Maybe it's a good idea if we can start local test server for testing. |
|
It looks like it was a bug actually, but still I think tests should not rely on the network. I'll make an issue; I've added tests so this is now ready for review :) |
ajnavarro
approved these changes
May 30, 2023
harry-hov
reviewed
Jun 18, 2023
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
harry-hov
approved these changes
Jun 19, 2023
moul
approved these changes
Jun 19, 2023
Doozers
pushed a commit
to Doozers/gno
that referenced
this pull request
Aug 31, 2023
* feat(cmd/gno): add support for gno.mod projects in gno doc * fix tests * remove bfsRootDir * update compat doc * add tests * harioms pr merged, remove duplicate code * fix: tests for wrong arguments passed to newDirs * xx * fix dirsempty * Apply suggestions from code review Co-authored-by: Hariom Verma <hariom18599@gmail.com> * s/tryParse/parse/g --------- Co-authored-by: Hariom Verma <hariom18599@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #522.
Feature is ready for review; will add some tests to check the functionality in all edge cases probably tomorrow.
Description
The
gno doccommand now understands local directories which usegno.mod.One of the caveats is that the command will likely always complains that it wants a
--root-dirvariable; but I think we'll need to find a system-wide solution for this eventually (ie. when gno comes out of the first phase of development, and users install it in/usr/lib/gno, this should default to that directory).(Sorry for the small font, I still had my terminal in full-screen...)
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the description