Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve the std API #848

Closed
wants to merge 3 commits into from
Closed

Conversation

moul
Copy link
Member

@moul moul commented May 24, 2023

  • Rename std.Get* -> std.*.
  • Return Frame struct{Addr,PkgPath} instead of string for std.Caller*.

Addresses #683

Contributors Checklist

  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

Maintainers Checklist

  • Checked that the author followed the guidelines in CONTRIBUTING.md
  • Checked the conventional-commit (especially PR title and verb, presence of BREAKING CHANGE: in the body)
  • Ensured that this PR is not a significant change or confirmed that the review/consideration process was appropriate for the change

Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul self-assigned this May 24, 2023
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label May 24, 2023
@moul moul changed the title chore: refactor std.Get helpers refacto: refactor std.Get helpers May 24, 2023
@moul moul changed the title refacto: refactor std.Get helpers refacto: refactor std helpers May 24, 2023
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@github-actions github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages. labels May 24, 2023
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@moul moul changed the title refacto: refactor std helpers refactor: improve the std API May 24, 2023
@thehowl
Copy link
Member

thehowl commented Jun 16, 2023

@moul what's the state on this? Are we holding it off awaiting decision / further discussion on Frames?

I think it might be good to merge std.Get* -> std.* in the meantime (I very much agree on that change) and maybe hold off frames management as per #683 ?

@moul
Copy link
Member Author

moul commented Jun 17, 2023

Yeah, let’s split into two PRs; feel free to continue my work, else I will work on it soon.

@moul moul added this to the 🚀 main.gno.land milestone Sep 6, 2023
@Kouteki Kouteki removed this from the 🚀 Mainnet launch milestone Oct 16, 2024
@thehowl
Copy link
Member

thehowl commented Oct 28, 2024

Let's continue on #2425

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Status: ✅ Done
Status: 🚀 Needed for Launch
Development

Successfully merging this pull request may close these issues.

3 participants