chore: use std.PrevRealm() in grc721 package #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
harry-hov
approved these changes
Jul 24, 2023
3 tasks
moul
approved these changes
Sep 22, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 47.00% 46.99% -0.01%
==========================================
Files 365 365
Lines 61159 61159
==========================================
- Hits 28747 28744 -3
- Misses 30058 30059 +1
- Partials 2354 2356 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gfanton
pushed a commit
to gfanton/gno
that referenced
this pull request
Nov 9, 2023
update (missing part of) grc721 package implementation to use `std.PrevRealm()` not `std.GetOrigCaller()` ## related gnolang#667 implementation of `std.PrevRealm()` gnolang#895 update grc20, 721 to use `std.PrevRealm()` <details><summary>Checklists...</summary> ## Contributors Checklist - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [x] Updated the official documentation or not needed - [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [x] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](../.benchmarks/README.md). </details> Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update (missing part of) grc721 package implementation to use
std.PrevRealm()notstd.GetOrigCaller()related
#667 implementation of
std.PrevRealm()#895 update grc20, 721 to use
std.PrevRealm()Checklists...
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the description