Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add gasEstimate function #42

Merged
merged 4 commits into from
Apr 8, 2025

Conversation

D4ryl00
Copy link
Collaborator

@D4ryl00 D4ryl00 commented Feb 5, 2025

This PR implements the EstimateGas function provided by Gnonative Kit (gnolang/gnonative#195). This function is called when a dapp wants to sign a transaction, and the gasWanted value is shown in this screen. So the user can accept or cancel the signature by knowing the gasWanted value.

@D4ryl00 D4ryl00 self-assigned this Feb 5, 2025
@D4ryl00 D4ryl00 marked this pull request as draft February 5, 2025 09:13
@D4ryl00 D4ryl00 force-pushed the feat/return-estimation-gas branch from 6c92597 to d5c711c Compare February 6, 2025 14:23
@D4ryl00 D4ryl00 force-pushed the feat/return-estimation-gas branch from d5c711c to 1023e7d Compare April 1, 2025 11:53
@D4ryl00 D4ryl00 requested a review from jefft0 April 1, 2025 12:23
@D4ryl00 D4ryl00 force-pushed the feat/return-estimation-gas branch from 1023e7d to 35fb9c7 Compare April 2, 2025 09:40
@D4ryl00 D4ryl00 requested a review from iuricmp April 2, 2025 09:48
@jefft0 jefft0 marked this pull request as ready for review April 4, 2025 09:24
Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS simulator. (Will test Android later.)

@iuricmp
Copy link
Collaborator

iuricmp commented Apr 4, 2025

Great job @D4ryl00 .

I think Redux-slice should be used to hold your functions at mobile/providers/indexer-provider.tsx. Any special reason to be a Provider?
I can do a new PR to change this.

D4ryl00 added 2 commits April 8, 2025 15:33
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
Signed-off-by: D4ryl00 <d4ryl00@gmail.com>
jefft0 added 2 commits April 8, 2025 17:12
…al session support

Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Signed-off-by: Jeff Thompson <jeff@thefirst.org>
Copy link
Collaborator

@jefft0 jefft0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android and iOS simulators.

@D4ryl00 D4ryl00 merged commit a5ed969 into gnolang:main Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants