Handle hover over package level globals

gnolang · Mar 30, 2024 · 75cca25 · 75cca25
1 parent 36f3de6
commit 75cca25
Showing 1 changed file with 40 additions and 7 deletions.
diff --git a/internal/lsp/hover.go b/internal/lsp/hover.go
@@ -80,22 +80,28 @@ func (s *server) Hover(ctx context.Context, reply jsonrpc2.Replier, req jsonrpc2
  }
  typeStr := tv.Type.String()
  m := mode(*tv)
- isLocalGlobal := strings.Contains(typeStr, pkg.ImportPath)
+ isPackageLevelGlobal := strings.Contains(typeStr, pkg.ImportPath) // better name
 
  // Handle builtins
  if doc, ok := isBuiltin(i, tv); ok {
  return hoverBuiltinTypes(ctx, reply, params, i, tv, m, doc)
  }
 
  // local var
- if (isLocalGlobal || !strings.Contains(typeStr, "gno.land")) && m == "var" {
- return hoverLocalVar(ctx, reply, params, pkg, i, tv, m, typeStr, isLocalGlobal)
+ if (isPackageLevelGlobal || !strings.Contains(typeStr, "gno.land")) && m == "var" {
+ return hoverLocalVar(ctx, reply, params, pkg, i, tv, m, typeStr, isPackageLevelGlobal)
  }
 
  // local type
- if isLocalGlobal && m == "type" {
+ if isPackageLevelGlobal && m == "type" {
  typeStr := parseType(typeStr, pkg.ImportPath)
- return hoverLocalTypes(ctx, reply, params, pkg, i, tv, m, typeStr)
+ return hoverPackageLevelTypes(ctx, reply, params, pkg, i, tv, m, typeStr)
+ }
+
+ // local global and is value
+ if m == "value" {
+ typeStr := parseType(typeStr, pkg.ImportPath)
+ return hoverPackageLevelValue(ctx, reply, params, pkg, i, tv, m, typeStr, isPackageLevelGlobal)
  }
 
  header := fmt.Sprintf("%s %s %s", m, i.Name, typeStr)
@@ -273,6 +279,33 @@ func (s *server) Hover(ctx context.Context, reply jsonrpc2.Replier, req jsonrpc2
  return reply(ctx, nil, nil)
 }
 
+// TODO: handle var doc
+func hoverPackageLevelValue(ctx context.Context, reply jsonrpc2.Replier, params protocol.HoverParams, pkg *Package, i *ast.Ident, tv *types.TypeAndValue, mode, typeStr string, isPackageLevelGlobal bool) error {
+ var header, body string
+ for _, s := range pkg.Symbols {
+ if s.Name == i.Name {
+ header = s.Signature
+ body = s.Doc
+ break
+ }
+ }
+
+ if header == "" {
+ return reply(ctx, nil, nil)
+ }
+
+ return reply(ctx, protocol.Hover{
+ Contents: protocol.MarkupContent{
+ Kind: protocol.Markdown,
+ Value: FormatHoverContent(header, body),
+ },
+ Range: posToRange(
+ int(params.Position.Line),
+ []int{int(i.Pos()), int(i.End())},
+ ),
+ }, nil)
+}
+
 // TODO: handle var doc
 func hoverLocalVar(ctx context.Context, reply jsonrpc2.Replier, params protocol.HoverParams, pkg *Package, i *ast.Ident, tv *types.TypeAndValue, mode, typeStr string, isLocalGlobal bool) error {
  t := typeStr
@@ -293,7 +326,7 @@ func hoverLocalVar(ctx context.Context, reply jsonrpc2.Replier, params protocol.
  }, nil)
 }
 
-func hoverLocalTypes(ctx context.Context, reply jsonrpc2.Replier, params protocol.HoverParams, pkg *Package, i *ast.Ident, tv *types.TypeAndValue, mode, typeName string) error {
+func hoverPackageLevelTypes(ctx context.Context, reply jsonrpc2.Replier, params protocol.HoverParams, pkg *Package, i *ast.Ident, tv *types.TypeAndValue, mode, typeName string) error {
  // Look into structures
  var structure *Structure
  for _, st := range pkg.Structures {
@@ -318,7 +351,7 @@ func hoverLocalTypes(ctx context.Context, reply jsonrpc2.Replier, params protoco
  }
  } else { // If not in structures, look into symbols
  for _, s := range pkg.Symbols {
- if s.Name == fmt.Sprintf("%s", typeName) {
+ if s.Name == i.Name {
  header = fmt.Sprintf("%s %s", mode, s.Signature)
  body = s.Doc
  break