Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change publish diagnostics to return params for a single file #2

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix: change publish diagnostics to return params for a single file #2

merged 1 commit into from
Aug 9, 2024

Conversation

jeronimoalbi
Copy link
Member

Changes textDocument/publishDiagnostics handler to only notify diagnostics for a single file

@jeronimoalbi
Copy link
Member Author

jeronimoalbi commented Jun 25, 2024 •
edited
Loading

This PR would fix an issue with vim's LSP client implementation which expects diagnostics notification for a single file.

It seems that in the spec textDocument/publishDiagnostics expects a single PublishDiagnosticsParams object as the notification params value. Previous implementation was returning an array with a single item.

zivkovicmilos
zivkovicmilos approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix 🙏

@jeronimoalbi jeronimoalbi self-assigned this Aug 9, 2024
@x1unix x1unix merged commit 864ad35 into gnolang:master Aug 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkovicmilos zivkovicmilos zivkovicmilos approved these changes

Assignees

@jeronimoalbi jeronimoalbi

Labels
None yet
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeronimoalbi @zivkovicmilos @x1unix