Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pr-triage.md #39

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

docs: add pr-triage.md #39

wants to merge 5 commits into from

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Mar 11, 2024

Description


## Objective

- Lower the time required for the feedback loop to at most 1 week for the biggest PRs, and 3-4 days for the regular ones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your text is good, but for anyone looking but I believe it's important to emphasize that the main goal is to shorten the feedback loop, not just the merging process. Shortening the feedback loop can speed up merging, but it's crucial to maintain quality and ensure reviews by the right code owners are mandatory, especially as time goes on.

Code owners, who may not be employees, are not required to strictly adhere to this employee convention.

We can implement an incentive model in the Review DAO to shorten the feedback loop by offering bonuses based on speed.

@Kouteki Kouteki self-requested a review May 8, 2024 10:53
Copy link
Collaborator

@Kouteki Kouteki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this proposal as an experiment that we can learn from and iterate, so let's do it now and make tweaks later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants