feat: change the data type to DeliverTx

gnolang · Nov 28, 2024 · 9efdbe7 · 9efdbe7
1 parent 9e45d2c
commit 9efdbe7
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 30 deletions.
diff --git a/src/provider/jsonrpc/jsonrpc.test.ts b/src/provider/jsonrpc/jsonrpc.test.ts
@@ -10,11 +10,11 @@ import {
   ABCIAccount,
   ABCIErrorKey,
   ABCIResponse,
-  ABCIResponseSimulateTx,
   BlockInfo,
   BlockResult,
   BroadcastTxSyncResult,
   ConsensusParams,
+  DeliverTx,
   NetworkInfo,
   RPCRequest,
   Status,
@@ -40,12 +40,16 @@ describe('JSON-RPC Provider', () => {
     });
     const expectedEstimation = 1000;
 
-    const mockSimulateResponse: ABCIResponseSimulateTx = {
-      Data: null,
-      Error: null,
-      Events: null,
-      GasWanted: 0,
-      GasUsed: expectedEstimation,
+    const mockSimulateResponse: DeliverTx = {
+      ResponseBase: {
+        Data: null,
+        Error: null,
+        Events: null,
+        Info: '',
+        Log: '',
+      },
+      GasWanted: '0',
+      GasUsed: expectedEstimation.toString(),
     };
 
     const mockABCIResponse: ABCIResponse = mock<ABCIResponse>();

diff --git a/src/provider/jsonrpc/jsonrpc.ts b/src/provider/jsonrpc/jsonrpc.ts
@@ -64,7 +64,7 @@ export class JSONRPCProvider implements Provider {
     const simulateResult = extractSimulateFromResponse(
       abciResponse.response.Value
     );
-    return simulateResult.GasUsed;
+    return parseInt(simulateResult.GasUsed);
   }
 
   async getBalance(

diff --git a/src/provider/types/abci.ts b/src/provider/types/abci.ts
@@ -47,12 +47,4 @@ export interface ABCIAccount {
   };
 }
 
-export interface ABCIResponseSimulateTx {
-  Error: string | null;
-  Data: string | null;
-  Events: any[] | null;
-  GasWanted: number;
-  GasUsed: number;
-}
-
 export const ABCIErrorKey = '@type';
diff --git a/src/provider/utility/provider.utility.ts b/src/provider/utility/provider.utility.ts
@@ -1,12 +1,12 @@
-import { ABCIAccount, ABCIResponseSimulateTx, BlockInfo } from '../types';
+import { sha256 } from '@cosmjs/crypto';
+import { Tx } from '../../proto';
+import { Provider } from '../provider';
+import { ABCIAccount, BlockInfo, DeliverTx } from '../types';
 import {
   base64ToUint8Array,
   parseABCI,
   uint8ArrayToBase64,
 } from './requests.utility';
-import { Provider } from '../provider';
-import { Tx } from '../../proto';
-import { sha256 } from '@cosmjs/crypto';
 
 /**
  * Extracts the specific balance denomination from the ABCI response
@@ -99,15 +99,15 @@ export const extractAccountNumberFromResponse = (
  */
 export const extractSimulateFromResponse = (
   abciData: string | null
-): ABCIResponseSimulateTx => {
+): DeliverTx => {
   // Make sure the response is initialized
   if (!abciData) {
     throw new Error('abci data is not initialized');
   }
 
   try {
     // Parse the account
-    return parseABCI<ABCIResponseSimulateTx>(abciData);
+    return parseABCI<DeliverTx>(abciData);
   } catch (e) {
     throw new Error('account is not initialized');
   }

diff --git a/src/provider/websocket/ws.test.ts b/src/provider/websocket/ws.test.ts
@@ -10,12 +10,12 @@ import {
   ABCIErrorKey,
   ABCIResponse,
   ABCIResponseBase,
-  ABCIResponseSimulateTx,
   BeginBlock,
   BlockInfo,
   BlockResult,
   BroadcastTxSyncResult,
   ConsensusParams,
+  DeliverTx,
   EndBlock,
   NetworkInfo,
   Status,
@@ -90,12 +90,16 @@ describe('WS Provider', () => {
     });
     const expectedEstimation = 1000;
 
-    const mockSimulateResponse: ABCIResponseSimulateTx = {
-      Data: null,
-      Error: null,
-      Events: null,
-      GasWanted: 0,
-      GasUsed: expectedEstimation,
+    const mockSimulateResponse: DeliverTx = {
+      ResponseBase: {
+        Data: null,
+        Error: null,
+        Events: null,
+        Info: '',
+        Log: '',
+      },
+      GasWanted: '0',
+      GasUsed: expectedEstimation.toString(),
     };
 
     const mockABCIResponse: ABCIResponse = {

diff --git a/src/provider/websocket/ws.ts b/src/provider/websocket/ws.ts
@@ -167,7 +167,7 @@ export class WSProvider implements Provider {
     const simulateResult = extractSimulateFromResponse(
       abciResponse.response.Value
     );
-    return simulateResult.GasUsed;
+    return parseInt(simulateResult.GasUsed);
   }
 
   async getBalance(