feat: Added primary indexes and GraphQL interface. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
thehowl
reviewed
Mar 5, 2024
thehowl
reviewed
Mar 5, 2024
ajnavarro
force-pushed
the
feature/indexes-on-storage
branch
from
6b2856a
to
01ff43f
Compare
zivkovicmilos
requested changes
Mar 11, 2024
There was a problem hiding this comment.
This looks great 💯
The feature is amazing, I really love it -- it's something I will actively use for all of my projects / clients.
The only thing that we need to change (keep) is the ability to keep lookups using transaction hashes, because it's a critical feature. I am completely in favor of having an index that maps hashes to the block number / tx index, but the ability to ask the indexer for the transaction result using a tx hash needs to stay.
Thank you for adding this feature, and for optimizing the way we utilize pebble - it was a joy to read 👏
thehowl
reviewed
Mar 14, 2024
zivkovicmilos
approved these changes
Mar 18, 2024
- Added graphQL API using 99designs/gqlgen. Really easy to use interface throught GraphQL playground, with a ton of extra documentation explaining all the Query functions and filter parameters. - Store Transactions by block height and index, making them queriable - Added a ton of special encoders on storage/encode.go. They are intended to be used as a fast, sortable way to encode/decode keys on any key/value store. That allows us to use advanced features when iterating keys, like adding upper and lower keys as limiters, or in the future adding secondary indexes. - BREAKING CHANGE: I had to change prefixes on pebble keys to make them queriable, so previous db states are invalid. - Added BlockIterator and TxIterator to Reader storage interface. Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
feature/indexes-on-storage
branch
from
c2cdb79
to
05edf24
Compare
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy, standard, graphQL API with documentation:
Easy filtering and data querying:
Subscriptions!: