feat: Implement generic filters #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajnavarro
requested review from
sw360cab,
mvertes,
zivkovicmilos and
jinoosss
ajnavarro
changed the title
Added new query API implementing a first version of generic filters. Some things are missing: - No subscriptions yet, almost there - No filters for multi type fields like messages, still thinking about how to implement the API to make it user friendly. Please, any feedback is welcome! Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
feature/add-generic-filters
branch
from
fcd6081
to
f4cb56a
Compare
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
ajnavarro
force-pushed
the
feature/add-generic-filters
branch
from
e709117
to
4d8cca2
Compare
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
|
i skimmed through the pr and i like the idea per-se; but i feel i'd need to play around with it to get a feeling and if it does what i need. can you or @sw360cab set up a quick server for checking this out? can be a 3$/mo machine to just try it out that we kill after a week. |
Signed-off-by: Antonio Navarro Perez <antnavper@gmail.com>
|
@thehowl do not hesitate to ask me anything/point out any strange API behavior you consider. We can sync to discuss your use cases when you have time. |
|
gladly, but i still haven't played with it so i don't have feedback yet! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a new query API to implement the first version of generic filters. The previous API is still working, I added this as an EXPERIMENTAL preview to gather feedback.
New features:
Please, any feedback is welcome!
Simple example query:
https://github.com/gnolang/tx-indexer/pull/90/files#diff-ab80be59ac3c22370754caec134ff00ed78559b8aefc392f485b730db636b44aR1-R14