Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

706 favorites bookmarks plugin #841

Merged

Conversation

vssdeo
Copy link
Contributor

@vssdeo vssdeo commented Oct 16, 2023

  • modified custom command plugin to have bookmarks
  • made name parsing of the custom command optional, so whole command can be added instead of the command being auto split into sub-menus. Default behavior is kept and a checkbox option is provided.
  • added keybindings for directly adding or launch the custom command menu
  • the dialog window taking command for bookmark via shortcut keybinding will have focus on OK Button for faster interaction

After enabling plugin KeyBindings available for fast adding custom command <Alt>b to launch custom command pref menu <Shift><Alt>b

vssdeo added 2 commits October 8, 2023 12:40
- modified custom command plugin to have bookmarks
- added keybindings for directly adding or launch the custom command menu
- made name parsing of the custom command optional
- the dialog window taking command for bookmark via shortcut keybinding will have focus on OK Button for faster interaction
- fixed a transient window issue for loading pref window via shortcut and context menu
- filed new command text area  was getting filled with last command
- fixed list store init
@mattrose
Copy link
Member

mattrose commented Feb 9, 2024

Looks good, thank you!

@mattrose mattrose merged commit 5c6fda2 into gnome-terminator:master Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants