Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Confirmation Modal Trust Wallet shows raw data #593

Closed
MareenG opened this issue May 5, 2021 · 11 comments
Closed

Confirmation Modal Trust Wallet shows raw data #593

MareenG opened this issue May 5, 2021 · 11 comments
Labels
app:CowSwap CowSwap app Enhancement New feature or request Wallets Wallet related

Comments

@MareenG
Copy link

MareenG commented May 5, 2021

Is your feature request related to a problem? Please describe.

The layout in the confirmation modal (trust wallet) is really bad. Can we somehow influence it, e.g. limit the info shown
1620206403639

@MareenG MareenG added Enhancement New feature or request app:CowSwap CowSwap app Mobile Affects mobile only Wallets Wallet related and removed Mobile Affects mobile only labels May 5, 2021
@alfetopito
Copy link
Contributor

I agree, it's awful.
Unfortunately, that's how they display the typed data via wallet connect.

One simple alternative for us would be to go straight to eth_sign instead of the typed data signature.
That's the fallback we use for Ledger and for Trustwallet itself when using the dApp browser.

The other option is reach out to them and ask for a nicer representation.

@anxolin
Copy link
Contributor

anxolin commented May 7, 2021

I'm inclined for the option to reach out to them.

@annamsgeorge maybe even tagging them in Tweeter. When we announce WC compatibility, we can tag directly trust wallet, with a picture and making them to present nicer the signed information

Maybe it happens faster, and also give us some visibility. WDYT?

@anxolin
Copy link
Contributor

anxolin commented May 7, 2021

Moving to current sprint, just to make a decision or reach the team and close this issue.

I don't think eth_sign is the way to go, because is a dangerous operation, it should disappear from the wallets in favour of the safer ones.
Some wallets like MM allow to use it, but they show a scary message.

@elena-zh
Copy link

HI there!
I was not able to connect the app with TrustWallet installed in iOS, while connection with the app in Android works fine.
Has anybody experienced this issue as well?

Thanks

@elena-zh
Copy link

Upd: the issue with iOS connection is related to a 'watch-only' wallet.
I have had imported watch-only account in my TrustWallet app, and I did not have a possibility to connect the app with the wallet.
In Android I got an explanation message about it...

@alfetopito
Copy link
Contributor

So, is the issue with the wallet on iOS?

@elena-zh
Copy link

The issue with the TrustWallet in iOS that it does not warn a user about using a 'watch-only' wallet there, that is why it is impossible to connect the app.

@alfetopito
Copy link
Contributor

I see. In that case, out of our control.
Could you report that on their repo, though? https://github.com/trustwallet/wallet-core/issues

@elena-zh
Copy link

Done!
trustwallet/wallet-core#1536

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you think it shouldn't be closed, speak now or forever hold your peace.

@stale stale bot added the wontfix Stale issue label Mar 2, 2022
@elena-zh elena-zh changed the title Confirmation Modal Trust Wallet Confirmation Modal Trust Wallet shows raw data Mar 2, 2022
@stale stale bot removed the wontfix Stale issue label Mar 2, 2022
@anxolin
Copy link
Contributor

anxolin commented Mar 4, 2022

Closing and creating trustwallet/wallet-core#2058

@anxolin anxolin closed this as completed Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app Enhancement New feature or request Wallets Wallet related
Projects
None yet
Development

No branches or pull requests

8 participants
@alfetopito @anxolin @MareenG @elena-zh and others