Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n: Market List Translation Strings #549

Open
andre-meyer opened this issue Oct 30, 2018 · 0 comments
Open

I18n: Market List Translation Strings #549

andre-meyer opened this issue Oct 30, 2018 · 0 comments
Labels
P2-Medium Medium Priority 💡Type: Feature Issue that corresponds to a new feature
Milestone
Localization

Comments

@andre-meyer
Copy link
Contributor

As a user, I want to see the Marketlist in my locale, so I can better understand it

Acceptance Criteria

  • Include all subcomponents for the Marketlist.
  • The markets itself won't have any support for i18n, they need to be created in the correct locale. This is not in the spec of this milestone.
  • Check for titles/popups/tooltips.

Screenshots/Mockups
@andre-meyer andre-meyer added 💡Type: Feature Issue that corresponds to a new feature P2-Medium Medium Priority labels Oct 30, 2018
@andre-meyer andre-meyer added this to the Localization milestone Oct 30, 2018
@andre-meyer andre-meyer mentioned this issue Nov 9, 2018
Merged
andre-meyer added a commit that referenced this issue Nov 12, 2018
@andre-meyer
Feature #549: Marketlist Translations (#563)
40dc291 
* finish translations on marketlist page

* add en translations

* missing string in form
andre-meyer added a commit that referenced this issue Nov 19, 2018
@andre-meyer
Upstream Merge (#570)
6091e8a 
* Deploy dist/embedded into /embedded

* Change public path for embedded

* embedded: Change browserrouter to hashrouter

* Feature #546: Header Translations (#562)

* wip translations

* finish header translations with subcomponents, reset default language

* remove language prop from i18n to be able to use queryparam

* fix missing css import

* fix css import

* fix embedding style

* Styles fix for embedded view

* Fix normalize.css import

* Feature #549: Marketlist Translations (#563)

* finish translations on marketlist page

* add en translations

* missing string in form

* hotfix: loading translation keys via webpack

* hotfix: font loading

* add dashboard translations

* hotfix: missing translation string

* finish market detail translation strings (#568)
mmv08 added a commit that referenced this issue Nov 20, 2018
@mmv08
Development (#572)
e786245 
* Deploy dist/embedded into /embedded

* Change public path for embedded

* embedded: Change browserrouter to hashrouter

* Feature #546: Header Translations (#562)

* wip translations

* finish header translations with subcomponents, reset default language

* remove language prop from i18n to be able to use queryparam

* fix missing css import

* fix css import

* fix embedding style

* Styles fix for embedded view

* Fix normalize.css import

* Feature #549: Marketlist Translations (#563)

* finish translations on marketlist page

* add en translations

* missing string in form

* hotfix: loading translation keys via webpack

* hotfix: font loading

* add dashboard translations

* hotfix: missing translation string

* finish market detail translation strings (#568)

* Merge master travis.yml

* remove autodll-webpack-plugin
mmv08 added a commit that referenced this issue Nov 21, 2018
@mmv08
Development (#573)
7e49006 
* Deploy dist/embedded into /embedded

* Change public path for embedded

* embedded: Change browserrouter to hashrouter

* Feature #546: Header Translations (#562)

* wip translations

* finish header translations with subcomponents, reset default language

* remove language prop from i18n to be able to use queryparam

* fix missing css import

* fix css import

* fix embedding style

* Styles fix for embedded view

* Fix normalize.css import

* Feature #549: Marketlist Translations (#563)

* finish translations on marketlist page

* add en translations

* missing string in form

* hotfix: loading translation keys via webpack

* hotfix: font loading

* add dashboard translations

* hotfix: missing translation string

* finish market detail translation strings (#568)

* Merge master travis.yml

* remove autodll-webpack-plugin

* Modify management dev deployment for both interface and embedded

* Add staging embedded deployment specs

* Feature #547: Modal Translations (#571)

* finish legal modals, finish reward claim modals

* finish installmetamask modal, register wallet modal

* fix linting errors

* add switch network modal, add transaction explanation, unlock modal, verification error-modal, outcome price changed modal

* add proptype for t

* add max_old_space_size to build-prod

* Fix translations merge
mmv08 added a commit that referenced this issue Nov 21, 2018
@mmv08
Development (#574)
0eb4c3b 
* Deploy dist/embedded into /embedded

* Change public path for embedded

* embedded: Change browserrouter to hashrouter

* Feature #546: Header Translations (#562)

* wip translations

* finish header translations with subcomponents, reset default language

* remove language prop from i18n to be able to use queryparam

* fix missing css import

* fix css import

* fix embedding style

* Styles fix for embedded view

* Fix normalize.css import

* Feature #549: Marketlist Translations (#563)

* finish translations on marketlist page

* add en translations

* missing string in form

* hotfix: loading translation keys via webpack

* hotfix: font loading

* add dashboard translations

* hotfix: missing translation string

* finish market detail translation strings (#568)

* Merge master travis.yml

* remove autodll-webpack-plugin

* Modify management dev deployment for both interface and embedded

* Add staging embedded deployment specs

* Feature #547: Modal Translations (#571)

* finish legal modals, finish reward claim modals

* finish installmetamask modal, register wallet modal

* fix linting errors

* add switch network modal, add transaction explanation, unlock modal, verification error-modal, outcome price changed modal

* add proptype for t

* add max_old_space_size to build-prod

* Fix translations merge

* Fix build-rpod command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2-Medium Medium Priority 💡Type: Feature Issue that corresponds to a new feature
Projects
None yet
Milestone
Localization
Development

No branches or pull requests
1 participant
@andre-meyer