Refactor PM-407: Outcome components #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o refactor/pm-407/outcome-components
…o refactor/pm-407/outcome-components
…o refactor/pm-407/outcome-components
…o refactor/pm-407/outcome-components
andre-meyer
suggested changes
Feb 22, 2018
| }) => ( | ||
| <div className="outcomes outcomes--categorical"> | ||
| <div className={cx('outcomeWrapper')}> | ||
| <div className="entry__color" style={entryStyle} /> |
There was a problem hiding this comment.
Why not use cx('entry') here?
There was a problem hiding this comment.
@andre-meyer Will fix that, this is related to the question I asked you today about adding class names for elements with no style imported from .scss
| const TrendingOutcomeCategorical = ({ | ||
| entryStyle, outcome, percentage, resolutionDate, | ||
| }) => ( | ||
| <div className="outcomes outcomes--categorical"> |
There was a problem hiding this comment.
cx('outcomes', 'categorical')
if we're going for css-modules, we need to use the bound styles everywhere
| @@ -60,6 +60,8 @@ module.exports = { | |||
| loader: 'css-loader', | |||
| options: { | |||
| sourceMap: true, | |||
| importLoaders: 2, | |||
There was a problem hiding this comment.
| @@ -60,6 +60,8 @@ module.exports = { | |||
| loader: 'css-loader', | |||
| options: { | |||
| sourceMap: true, | |||
| importLoaders: 2, | |||
| localIdentName: '[name]--[local]--[hash:base64:8]', | |||
There was a problem hiding this comment.
Doesn't this break all previously declared global css?
There was a problem hiding this comment.
@andre-meyer Right now it doesn't, it will break after we set modules: true, this is just some kind of preparation for names 😃
…o refactor/pm-407/outcome-components
andre-meyer
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
components/OutcomeTrendingOutcomeScalarandTrendingOutcomeCategoricalwebpack.config.dev.jsfor CSS modules