Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Suggestion) 127- organize partials by folder #230

Merged
merged 3 commits into from
Nov 22, 2022
Merged

(Suggestion) 127- organize partials by folder #230

merged 3 commits into from
Nov 22, 2022

Conversation

plato-gno
Copy link
Contributor

What

  • Since we are going to be heavily reliant on _partials, I would like to suggest partials be organized by folder
  • I have done a sample reorg on the validators folder
  • If we're ok with this, I'll adopt this for the remaining sections

Refs

@plato-gno plato-gno changed the base branch from main to 127-validators November 22, 2022 10:52
@alebanzas alebanzas mentioned this pull request Nov 22, 2022
Merged
41 tasks
alebanzas
alebanzas approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@alebanzas alebanzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great recommendation

@alebanzas alebanzas merged commit 69a9da6 into 127-validators Nov 22, 2022
@alebanzas alebanzas deleted the 127-organize-partials-by-folder branch November 23, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alebanzas alebanzas alebanzas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plato-gno @alebanzas