Encalve Spec #1
Merged
Encalve Spec #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly invoke the setup as fixture in each test - this is faster and cleaner
auryn-macmillan
commented
Jun 3, 2024
| // note that this.owner is msg.sender in both cases | ||
| const enclave = await this.Enclave.deploy(this.otherAccount.address, this.otherAccount.address, this.maxDuration); | ||
| const owner2 = await enclave.owner(); | ||
| const [, , , otherOwner, otherRegistry] = await ethers.getSigners(); |
There was a problem hiding this comment.
Should we just add this to the fixture, since a similar call is repeated a few times throughout the tests?
…20 was too wide, 100 is closer to the default of 80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specifies the Enclave protocol in a suite of unit tests, along with implementing Mock contracts for each of the various modular components.