Merge main after changes #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First attempt at accumulating inputs in a binary incremental merkle tree. Currently failing with `Error: Transaction reverted without a reason string` when I try to insert an input into the tree `BinaryIMT.insert(inputs[e3Id], inputHash);`.
This commit replaces BinaryIMT with LeanIMT, which resolved the errors in the previous commit. I've also removed the inputs array from the E3 struct, so inputs are no longer stored on-chain. There seems to be some limit to how large items in the trees can be. A hack solution is to divide the inputHash by `10 ** 39`.
In previous commits, I was hitting errors with the Poseidon library. It seems to be an issue with the deterministic deployments and hardhat network, being tracked [here](https://github.com/privacy-scaling-explorations/zk-kit.solidity/issues/38). By deploying the Poseidon Lib directly, the issue was resolved. Note that this required adding an override to the compiler settings.
Incrementally build a merkle tree from published inputs
Update language
feat: update sequence diagram
fix: computationModule -> e3Program
feat: emit seed and params
… `IComputeProvider`
…module-calls feat: add `e3Id` and `seed` to `validate()` calls to `IE3Program` and `IComputeProvider`
feat: store ciphernode in an incremental merkle tree
Better deploy script
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.