Fast witness generation #1
Open
+396
−197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tracing = "0.1.40" | ||
| tracing-subscriber = { version = "0.3.17", features = ["std", "env-filter"] } | ||
| tracing-forest = { version = "0.1.6", features = ["ansi", "smallvec"] } | ||
| concrete-ntt = { git = "https://github.com/zama-ai/concrete-ntt", features = [ |
There was a problem hiding this comment.
@fhedude, fhe.rs already implements NTT, no? Perhaps we can use fhe.rs' implementation to avoid adding another dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
poly_div_cycloandpoly_modulo_cyclothat leverage structure of cyclotomic polypoly_divrecursively using "divide-and-conquer" strategy.Known issue
concrete-nttnative NTT plan fails for poly sizes > 2**15`Possible future work
r1iandp1ican be converted to field elements modulo some suitablepcan apply batch multiplicative inverse (Mongomery trick) to further optimizepoly_div(currently takes about ~80ms forn=2**14)