-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Migration to Zodiac Core and Task Improvements in Delay Module #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
juliopavila
changed the title
Use zodiac core
Feat: Migration to Zodiac Core and Task Improvements in Delay Module
Aug 20, 2024
I have read the CLA Document and I hereby sign the CLA |
recheck |
samepant
approved these changes
Aug 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This Pull Request focuses on the integration of the new Zodiac Core package across the Delay module. The key objective is to replace the previous Gnosis Zodiac dependencies with the newly established Zodiac Core to enhance modularity and reduce tightly coupled dependencies.
Key Changes:
Migration to Zodiac Core:
@gnosis.pm/zodiac
with the new@gnosis-guild/zodiac-core
.Delay.sol
,TestFactory.sol
, and other contracts to reflect these changes.Task Improvements:
deploy:mastercopies
: Deploys all mastercopies.deploy:mastercopy --contract-version <version>
: Deploys a specific version of a mastercopy.verify:mastercopies
: Verifies all mastercopies.verify:mastercopy --contract-version <version>
: Verifies a specific version of a mastercopy.Configuration Updates:
hardhat.config.ts
to import new task files and include new network configurations like Sepolia.Package and Dependency Upgrades:
@gnosis-guild/zodiac-core
and removed the old Zodiac dependencies.Test Suite Updates:
Delay.spec.ts
to ensure they work with the refactored contract logic.Solution:
The solution involved refactoring existing contracts and tasks to use Zodiac Core. This makes the system more modular and reduces the risk of introducing bugs during future updates. The new approach also enhances the clarity of the codebase, making it easier for developers to work with.