-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Delay module is zodiac compliant #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auryn-macmillan
requested changes
Aug 7, 2021
cbrzn
force-pushed
the
feat/zodiac-compliant
branch
from
August 7, 2021 04:11
2315630
to
8d26c95
Compare
cbrzn
force-pushed
the
feat/zodiac-compliant
branch
from
August 7, 2021 04:17
8d26c95
to
ed3d91e
Compare
auryn-macmillan
approved these changes
Aug 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
CI is broken because of an error in solidity coverage package due to London fork: sc-forks/solidity-coverage#652 |
cbrzn
force-pushed
the
feat/zodiac-compliant
branch
from
August 9, 2021 11:39
7e7d41f
to
c777431
Compare
cbrzn
force-pushed
the
feat/zodiac-compliant
branch
from
August 9, 2021 16:09
f8ec8f4
to
984cb0b
Compare
cbrzn
commented
Aug 9, 2021
cbrzn
force-pushed
the
feat/zodiac-compliant
branch
from
August 9, 2021 18:40
180fbf7
to
83a8f10
Compare
auryn-macmillan
approved these changes
Aug 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes suggested on this PR: