Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Delay module is zodiac compliant #6

Merged
merged 9 commits into from
Aug 10, 2021

Conversation

cbrzn
Copy link
Collaborator

@cbrzn cbrzn commented Aug 7, 2021

Changes suggested on this PR:

  • Delay module extends from Modifier abstract contract. Making the contract Ownable and has the attribute executor
  • The ownership of the contract is transferred on set up function to executor

@cbrzn cbrzn requested a review from auryn-macmillan August 7, 2021 02:27
contracts/DelayModule.sol Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@cbrzn cbrzn force-pushed the feat/zodiac-compliant branch from 2315630 to 8d26c95 Compare August 7, 2021 04:11
@cbrzn cbrzn force-pushed the feat/zodiac-compliant branch from 8d26c95 to ed3d91e Compare August 7, 2021 04:17
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cbrzn
Copy link
Collaborator Author

cbrzn commented Aug 7, 2021

CI is broken because of an error in solidity coverage package due to London fork: sc-forks/solidity-coverage#652

@cbrzn cbrzn force-pushed the feat/zodiac-compliant branch from 7e7d41f to c777431 Compare August 9, 2021 11:39
@cbrzn cbrzn force-pushed the feat/zodiac-compliant branch from f8ec8f4 to 984cb0b Compare August 9, 2021 16:09
package.json Outdated Show resolved Hide resolved
@cbrzn cbrzn force-pushed the feat/zodiac-compliant branch from 180fbf7 to 83a8f10 Compare August 9, 2021 18:40
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@auryn-macmillan auryn-macmillan merged commit f3274df into main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants