Cannot connect to Etherscan if MetaMask is enabled

[jfschwarz]

Describe the bug
Up until very recently you could connect Etherscan to Pilot to capture calls encoded there. This no longer seems possible

To Reproduce
Steps to reproduce the behavior:

1. Go to https://etherscan.io/address/0x27d8bb2e33Bc38A9CE93fdD90C80677b8436aFfb#writeContract
2. Open Pilot panel
3. Click on Connect to Web3 button in Etherscan
4. Select MetaMask in the modal

It's now connected to MetaMask.

Expected behavior
It should be connected to Pilot. This used to work (even though the button always said MetaMask).

[jfschwarz]

same problem on https://abi.ninja

[frontendphil]

It works when I use Rabby. But, as you said, it won't when I have the MetaMask extension running. Maybe this also has something to do with our current issues connecting MetaMask... I'll put some more work into externalizing the route configuration and will then get back to this.

[frontendphil]

I've looked at the Etherscan code, and when you click "MetaMask," they select the provider by name. Since we are nice enough to register as "Zodiac" and not "MetaMask," this throws us out and uses the meta mask provider that announced itself with the respective name.

I'll need some more time to look into ways how to solve this.

[jfschwarz]

I've looked at the Etherscan code, and when you click "MetaMask," they select the provider by name. Since we are nice enough to register as "Zodiac" and not "MetaMask," this throws us out and uses the meta mask provider that announced itself with the respective name.

I'll need some more time to look into ways how to solve this.

We could simply maintain a list of hostnames where we impersonate metamask, also by setting the provider name.

[jfschwarz]

Seems this is not yet fixed and should not haven been marked as completed

[frontendphil]

@jfschwarz, it seems like you've clicked the wrong button ;)

I've added the list you were talking about, which partially solves this issue. We're now able to connect at all. However, as soon as the meta mask extension is active in the browser, it will always take precedence over ours. This might be a general issue but I'll need to further look into this to be sure.

If it's a more general issue, I'll open up another bug and close this one. Otherwise, I'll keep working in this ticket.