Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch chain not working #268

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

frontendphil
Copy link
Member

Fixes #263

@jfschwarz I couldn't reproduce the issue you've faced. AFAICT, all the messages end up where they should be, and the responses look OK. However, I see that Rabby (on my machine) doesn't show that it updated the chain. So, I wonder whether we only talk to ourselves and the message never goes through. Love to have a look together with you on this one to verify what is going on.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 0:49am

Copy link

github-actions bot commented Dec 9, 2024

Coverage Report for extension

Status Category Percentage Covered / Total
🔵 Lines 60.31% 4916 / 8150
🔵 Statements 60.31% 4916 / 8150
🔵 Functions 66.14% 295 / 446
🔵 Branches 77.57% 730 / 941
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
extension/src/inject/injectedScript/InjectedProvider.ts 0% 0% 0% 0% 1-142
extension/src/panel/providers/injected-provider/ConnectProvider.ts 34.07% 70% 50% 34.07% 17-19, 38-41, 46, 72-76, 80-97, 100-146, 162-198
extension/src/panel/providers/injected-provider/useConnectProvider.tsx 53.22% 91.66% 62.5% 53.22% 54-56, 66-67, 83-87, 105-169
extension/src/panel/providers/injected-provider/port/createPort.ts 88.23% 75% 100% 88.23% 27-28, 57-58, 72-73
Generated in workflow #943 for commit 2738858 by the Vitest Coverage Report Action

Copy link

cloudflare-workers-and-pages bot commented Dec 9, 2024

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2738858
Status: ✅  Deploy successful!
Preview URL: https://e06fc85f.zodiac-pilot.pages.dev
Branch Preview URL: https://fix-switch-chain-not-working.zodiac-pilot.pages.dev

View logs

@frontendphil frontendphil merged commit 9dcffea into main Dec 9, 2024
7 checks passed
@frontendphil frontendphil deleted the fix/switch-chain-not-working branch December 9, 2024 13:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain switch not working
1 participant