Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch edit route to action #349

Merged
merged 9 commits into from
Dec 13, 2024

Conversation

frontendphil
Copy link
Member

Handle route updates through actions. Removes all client hooks to modify chrome storage. With this PR, all data loads and writes happen next to the UI. This means that the UI doesn't care where exactly the data is coming from. This decouples this concern, which will make it easier in the future to store routes not only locally but also centrally in a service.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-example-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 3:28pm

Copy link

Coverage Report for extension

Status Category Percentage Covered / Total
🔵 Lines 63.17% 5234 / 8285
🔵 Statements 63.17% 5234 / 8285
🔵 Functions 71.24% 327 / 459
🔵 Branches 78.23% 791 / 1011
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
extension/src/components/InlineForm.tsx 100% 100% 100% 100%
extension/src/components/buttons/BaseButton.tsx 100% 82.35% 100% 100%
extension/src/panel/app.tsx 0% 0% 0% 0% 1-68
extension/src/panel/execution-routes/ExecutionRouteContext.tsx 100% 100% 100% 100%
extension/src/panel/execution-routes/index.ts 100% 100% 100% 100%
extension/src/panel/pages/$activeRouteId/ActiveRoute.tsx 93.33% 80% 100% 93.33% 40-43
extension/src/panel/pages/$activeRouteId/intents.ts 100% 100% 100% 100%
extension/src/panel/pages/routes/edit.$routeId/EditRoute.tsx 81.32% 66.66% 66.66% 81.32% 88-89, 222-223, 225-229, 266-272, 276-285, 303-310, 321-329, 338-340, 353, 358-360
extension/src/panel/pages/routes/edit.$routeId/RemoveButton.tsx 100% 100% 75% 100%
extension/src/panel/pages/routes/edit.$routeId/intents.ts 100% 100% 100% 100%
extension/src/panel/utils/index.ts 100% 100% 100% 100%
extension/src/utils/formData.ts 100% 100% 100% 100%
extension/src/utils/getInt.ts 100% 100% 100% 100%
extension/src/utils/getOptionalString.ts 100% 100% 100% 100%
extension/src/utils/index.ts 100% 100% 100% 100%
Generated in workflow #109 for commit 39d219e by the Vitest Coverage Report Action

@frontendphil frontendphil merged commit 49ee0b0 into main Dec 13, 2024
12 checks passed
@frontendphil frontendphil deleted the chore/switch-edit-route-to-action branch December 13, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant