Fix guardable #109
Merged
Fix guardable #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auryn-macmillan
changed the base branch from
master
to
add-setupModules()-function-to-Modifier.sol
…new factory address)
jfschwarz
reviewed
Feb 9, 2023
contracts/guard/Guardable.sol
Outdated
Comment on lines
28
to
30
| function getGuard() external view returns (address _guard) { | ||
| return guard; | ||
| } |
There was a problem hiding this comment.
ok, now this needs a major version bump. but good to remove this obsolete getter 👍
There was a problem hiding this comment.
I realized that we can't remove this, otherwise it makes our guards incompatible with the Safe.
cristovaoth
approved these changes
Feb 9, 2023
Upgrade-to-latest-oz
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug
Implementation
This PR fixes an issue with our current guard implementation, where it was possible for a transaction to disable the current guard and thus bypass the
guard.checkAfterExecutioncall.To address this,
guardis now buffered inexecandexecAndReturnDatacalls, rather than being read from storage each time it is accessed.The fix should also make each
execorexecAndReturnDatacall a little more gas efficient.Audit
TODO
Checklist
Prior to being merged, this PR must meet the following requirements.
This PR: