Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve: Update addresses for Optimistic Governor v2 #114

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Improve: Update addresses for Optimistic Governor v2 #114

merged 2 commits into from
Apr 5, 2023

Conversation

abg4
Copy link
Contributor

@abg4 abg4 commented Mar 30, 2023

Implementation

This PR updates the optimistic governor contract addresses and ABI to use the v2 version of the Optimistic Governor contract.

See https://github.com/UMAprotocol/protocol/blob/master/packages/core/contracts/optimistic-governor/implementation/OptimisticGovernor.sol for the updated contract.

abg4 added 2 commits March 30, 2023 13:24
@abg4
Update ABI to og v2
98c7826 
Signed-off-by: Alex Gaines <againes@umaproject.org>
@abg4
Update og contract addresses
5313285 
Signed-off-by: Alex Gaines <againes@umaproject.org>
@abg4 abg4 marked this pull request as ready for review April 3, 2023 20:58
@abg4 abg4 mentioned this pull request Apr 3, 2023
Merged
@abg4
Copy link
Contributor Author

abg4 commented Apr 3, 2023

I noticed in src/deployments.json not all networks are included. The front-end seems to use the contracts.ts file so I didn't add missing networks but I did update the contracts for existing networks. Let me know if you would like me to add the other networks.

auryn-macmillan
auryn-macmillan approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@auryn-macmillan auryn-macmillan merged commit bc02682 into gnosisguild:master Apr 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abg4 @auryn-macmillan