Add addresses of legacy mastercopies #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auryn-macmillan
approved these changes
May 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have multiple users of the Roles legacy deployments. (We re-deployed all mastercopies through the latest module factory at some point.) For these legacy Roles instances, the zodiac app does not show the "Edit roles" links, which is causing frustration.
We detect modules by mastercopy address, but this package did not provide addresses of historic versions. This has been added in this PR with the new
ContractVersionsexport. I also tried to clean up some mess in how we keep the contract information (deployment.json was not even being used) and how the package is built.Once this is released, I will be able to fix the issue of missing "Edit roles" links in the zodiac Safe app.