-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Develop Earn Page Layout Component #191
Merged
juntaepark
merged 1 commit into
develop
from
GSFE-254-pool-details-develop-earn-page-layout-component
Aug 29, 2023
Merged
feat: Develop Earn Page Layout Component #191
juntaepark
merged 1 commit into
develop
from
GSFE-254-pool-details-develop-earn-page-layout-component
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d409213
to
e9b3fa6
Compare
a6bfc3f
to
dbace73
Compare
jinoosss
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I left a few comments.
packages/web/src/components/earn/pool-list-table/PoolListTable.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/earn/pool-list/PoolList.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/common/my-position-card-list/MyPositionCardList.stories.tsx
Show resolved
Hide resolved
packages/web/src/components/common/my-position-card-list/MyPositionCardList.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/earn/earn-my-positions-content/EarnMyPositionsContent.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/earn/incentivized-pool-card-list/IncentivizedPoolCardList.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/pool/my-position-card/MyPositionCard.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/pool/pool-pair-info-content/PoolPairInfoContent.stories.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/pool/pool-pair-information/PoolPairInformation.stories.tsx
Outdated
Show resolved
Hide resolved
5182187
to
ba58b0c
Compare
ba58b0c
to
a533602
Compare
jinoosss
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.