Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSW-413] fix: Wallet Improve UI #225

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Conversation

khiemldk
Copy link
Contributor

No description provided.

@khiemldk khiemldk requested a review from harryoh October 27, 2023 08:58
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 83 resolved Oct 30, 2023 7:39am

Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khiemldk ,
Nicely done.
I left some comments.

And I checked that you implemented a modal.
I was trying to make it work by replacing the content in a common ModalContainer,
Do you think it's better to implement each modal separately?

@khiemldk
Copy link
Contributor Author

@khiemldk , Nicely done. I left some comments.

And I checked that you implemented a modal. I was trying to make it work by replacing the content in a common ModalContainer, Do you think it's better to implement each modal separately?

@jinoosss , I tried to create each method separately because some previous commits separate. But maybe I can reuse the Modal container to do it better. But there are quite a few separate Modal methods being developed. What do you think if I create separate PR for this part?

@jinoosss
Copy link
Member

I tried to create each method separately because some previous commits separate. But maybe I can reuse the Modal container to do it better. But there are quite a few separate Modal methods being developed. What do you think if I create separate PR for this part?

@khiemldk, I agree.
I think it would be a good idea to create a separate PR and work on it.

jinoosss
jinoosss previously approved these changes Oct 30, 2023
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@akstar82 akstar82 merged commit c363d3e into develop Oct 30, 2023
@jinoosss jinoosss deleted the GSW-413-Wallet-Improve-UI branch October 30, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants