-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSW-413] fix: Wallet Improve UI #225
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khiemldk ,
Nicely done.
I left some comments.
And I checked that you implemented a modal.
I was trying to make it work by replacing the content in a common ModalContainer,
Do you think it's better to implement each modal separately?
packages/web/src/components/common/select-token/SelectToken.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/components/common/select-token/SelectToken.tsx
Outdated
Show resolved
Hide resolved
@jinoosss , I tried to create each method separately because some previous commits separate. But maybe I can reuse the Modal container to do it better. But there are quite a few separate Modal methods being developed. What do you think if I create separate PR for this part? |
1c2b73d
to
a467c88
Compare
@khiemldk, I agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
a467c88
to
2741c42
Compare
No description provided.