Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSW-556] feat: Implements Swap Router #234

Merged
merged 18 commits into from
Nov 30, 2023

Conversation

jinoosss
Copy link
Member

No description provided.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 2:54am

@jinoosss jinoosss requested a review from r3v4s November 29, 2023 11:58
@r3v4s
Copy link
Member

r3v4s commented Nov 30, 2023

@jinoosss before dive into review, is chaining .yarn/cache necessary?

@jinoosss
Copy link
Member Author

@jinoosss before dive into review, is chaining .yarn/cache necessary?

Yes. The gnoswap interface uses a cache to enable plug and play of the yarn workspace.

@jinoosss jinoosss force-pushed the GSW-556-calculate-swap-pool-path branch from d34d671 to 2bcf2bc Compare November 30, 2023 02:53
@r3v4s
Copy link
Member

r3v4s commented Nov 30, 2023

saw everything except bunch of cache thing

@jinoosss jinoosss merged commit ea316ff into GSW-488-swap-route Nov 30, 2023
5 checks passed
@jinoosss jinoosss deleted the GSW-556-calculate-swap-pool-path branch November 30, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants