Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rerender chart in add position #511

Merged

Conversation

jinoosss
Copy link
Member

Descriptions

Based on #509 ,
modify the rendering conditions for the graph on the add position page.

Copy link

vercel bot commented Aug 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 4:54am

@jinoosss jinoosss changed the base branch from develop to GSW-1486-quick-pool-info August 25, 2024 04:54
@jinoosss jinoosss requested a review from AkydA August 25, 2024 04:54
Copy link

sonarcloud bot commented Aug 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.2% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@jinoosss
Copy link
Member Author

This PR will be merged into the #509.

@jinoosss jinoosss requested a review from dongwon8247 August 25, 2024 05:10
@dongwon8247
Copy link
Member

Thank you for the fix

@dongwon8247 dongwon8247 merged commit 572af61 into GSW-1486-quick-pool-info Aug 25, 2024
4 of 5 checks passed
@dongwon8247 dongwon8247 deleted the GSW-1486-quick-pool-info-rerender branch August 25, 2024 06:37
AkydA added a commit that referenced this pull request Aug 26, 2024
* refactor: remove meaningless state

* feat: add param for PoolAdd view option

* feat: add hook for parsing serach param

* feat: introduce AdditionalInfo component

* fix: search param routing

* feat: show graph when pool exist

* fix: QA issues

* fix: fix rerender chart in add position (#511)

* fix: exchange rate tooltip width

---------

Co-authored-by: jinoosss <112360739+jinoosss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants