Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1561 Imporove Governance UI #527

Merged
merged 12 commits into from
Sep 6, 2024
Merged

GSW-1561 Imporove Governance UI #527

merged 12 commits into from
Sep 6, 2024

Conversation

AkydA
Copy link
Contributor

@AkydA AkydA commented Sep 4, 2024 •
edited
Loading

Description

  • apply infinity scroll
  • add tx modals
  • refactor: local modal hoc

@AkydA AkydA self-assigned this Sep 4, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:39am

@AkydA AkydA marked this pull request as ready for review September 5, 2024 08:38
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
30.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

jinoosss
jinoosss approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@jinoosss jinoosss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/web/src/components/hoc/with-intersection/index.ts Show resolved Hide resolved
packages/web/src/views/governance/hooks/use-governance-tx.tsx Show resolved Hide resolved
...web/src/views/governance/components/proposals-list/view-proposal-modal/ViewProposalModal.tsx Show resolved Hide resolved
@AkydA AkydA requested review from notJoon and r3v4s September 5, 2024 09:17
@AkydA AkydA merged commit 5001c3a into develop Sep 6, 2024
4 of 5 checks passed
@AkydA AkydA deleted the GSW-1561 branch September 6, 2024 01:31
This was referenced Nov 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

@r3v4s r3v4s r3v4s approved these changes

@notJoon notJoon Awaiting requested review from notJoon

Assignees

@AkydA AkydA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkydA @r3v4s @jinoosss