Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : Update proposal no data text, Implement responsive text sizing for Current price section #533

Merged
merged 2 commits into from
Sep 29, 2024

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Sep 26, 2024

  • Update "No data found" text to "No proposal found" in Governance page
  • Implement responsive text sizing for Current price section in Earn page

…e page

- Todo: Update corresponding text in other supported languages
- Changed the text displayed when no data is available in the Governance Proposals component
- Apply the same responsive text sizing logic used in Price Range to Current Price numbers
- Adjust text size based on the maximum length of the applied area in Price Range
- Maintain current spacing, only modifying text size for consistency
- Improve readability and visual consistency across price display sections
Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 3:55am

@tfrg tfrg requested a review from onlyhyde September 26, 2024 04:06
@onlyhyde onlyhyde requested a review from jinoosss September 26, 2024 04:41
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.2% Coverage on New Code (required ≥ 80%)
23.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dongwon8247 dongwon8247 merged commit d8432a8 into develop Sep 29, 2024
4 of 5 checks passed
@dongwon8247 dongwon8247 deleted the update-proposal-no-data-text branch September 29, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants