Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [GSW-1739]: After the transaction executes, the modal close #547

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix [GSW-1739]: After the transaction executes, the modal close #547

merged 2 commits into from
Oct 29, 2024

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Oct 29, 2024

Fixed

  • The Launchpad modal exits automatically when a transaction is executed

@tfrg tfrg requested review from onlyhyde and jinoosss October 29, 2024 02:07
@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 2:46am

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
10.3% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@tfrg tfrg merged commit f580278 into develop Oct 29, 2024
5 of 6 checks passed
@tfrg tfrg deleted the GSW-1739-fix-launchpad-modal-close branch October 29, 2024 08:49
This was referenced Nov 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinoosss jinoosss jinoosss approved these changes

@onlyhyde onlyhyde onlyhyde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tfrg @onlyhyde @jinoosss