Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix [GSW-1960] Token Price NaN #568

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

tfrg
Copy link
Collaborator

@tfrg tfrg commented Nov 20, 2024

Purpose

Fixes an issue where an invalid result (NaN) is displayed directly in the UI when calculating the USD value of a token on the HomeSwap page.

Description

  • 'NaN' was exposed directly in the UI when calculating the USD value of a token resulted in an invalid result
  • Technical error messages that break user experience
  • Modify logic to return null if the result of a calculation is invalid (NaN)

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnoswap-interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 10:52am

@tfrg tfrg force-pushed the GSW-1960-token-price-nan-display branch from 5c15b7b to 56cb7e6 Compare November 20, 2024 10:50
Copy link

sonarcloud bot commented Nov 20, 2024

@tfrg tfrg merged commit 7ba9adf into develop Nov 20, 2024
6 checks passed
@tfrg tfrg deleted the GSW-1960-token-price-nan-display branch November 20, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants