feat: [GSW-1975] SwapState Loading & Insufficient Liquidity #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
notJoon
previously approved these changes
Dec 13, 2024
Refactor this getter to return a value. Getters and setters should access the expected fields typescript:S4275 Software qualities impacted: Reliability
Provide a compare function to avoid sorting elements alphabetically. "Array.prototype.sort()" and "Array.prototype.toSorted()" should use a compare function typescript:S2871 Software qualities impacted: Reliability
Fix SonarQube issue by removing direct .sort() comparison in test assertions
Remove this duplicated type or replace with another one. Union and intersection types should not include duplicated constituents typescript:S4621 Software qualities impacted: Maintainability
Refactor this redundant 'await' on a non-promise. "await" should only be used with promises typescript:S4123 Software qualities impacted: Maintainability
Move this "default" clause to the end of this "switch" statement. "default" clauses should be last typescript:S4524 Software qualities impacted: Maintainability
Refactor this function to reduce its Cognitive Complexity from 60 to the 15 allowed. Cognitive Complexity of functions should not be too high typescript:S3776 Software qualities impacted: Maintainability
Refactor this function to reduce its Cognitive Complexity from 60 to the 15 allowed. Cognitive Complexity of functions should not be too high typescript:S3776 Software qualities impacted: Maintainability
Refactor this function to reduce its Cognitive Complexity from 60 to the 15 allowed. Cognitive Complexity of functions should not be too high typescript:S3776 Software qualities impacted: Maintainability
Make sure not using "noopener" is safe here. Authorizing an opened window to access back to the originating window is security-sensitivetypescript:S5148
… operator Extract this nested ternary operation into an independent statement. Ternary operators should not be nested typescript:S3358 Software qualities impacted: Maintainability
tfrg
force-pushed
the
GSW-1975-add-swap-route-loading
branch
from
d1f04b0 to
2efe011
Compare
- Simplify array concatenation using spread operator and join - Keep null/zero amount check for preventing unnecessary API calls - Maintain proper handling of decimal input cases (0 -> 0.1 -> 0.12)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details
-Implement estimatedLiquidityMax-based fetch control