Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-846: feat: uint256, int256 instead of bigint #188

Merged
merged 4 commits into from
Mar 11, 2024
Merged

GSW-846: feat: uint256, int256 instead of bigint #188

merged 4 commits into from
Mar 11, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Mar 6, 2024 •
edited
Loading

New

  1. uint256 (REF: https://github.com/holiman/uint256)
  2. int256 (REF: https://github.com/mempooler/int256)

# WIP
u256 * u256 overflow handling

co worker: @notJoon @mconcat

@r3v4s r3v4s requested review from notJoon and mconcat March 6, 2024 12:23
@r3v4s r3v4s self-assigned this Mar 6, 2024
@r3v4s r3v4s marked this pull request as ready for review March 7, 2024 08:40
mconcat
mconcat approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@mconcat mconcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all these work, including int256 and nice integrations! Few comments are left like some questions, but I think this one is good to be merged.

@r3v4s
Copy link
Member Author

r3v4s commented Mar 11, 2024

Thanks for making all these work, including int256 and nice integrations! Few comments are left like some questions, but I think this one is good to be merged.

Replied all of your comments, and resolved if it was just comment.
If all of replies looks good, please resolve conversation.

@notJoon notJoon merged commit d2e57ca into main Mar 11, 2024
@notJoon notJoon deleted the GSW-846-uint256-int256 branch March 11, 2024 01:50
@adr-sk adr-sk mentioned this pull request Mar 13, 2024
Open
@michelleellen michelleellen mentioned this pull request Mar 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mconcat mconcat mconcat approved these changes

@notJoon notJoon notJoon approved these changes

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r3v4s @notJoon @mconcat