Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSW-1037 apply emit event in contract #217

Merged
merged 10 commits into from
May 16, 2024
Merged

GSW-1037 apply emit event in contract #217

merged 10 commits into from
May 16, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented May 15, 2024 •
edited
Loading

New

  1. apply emit & event for pool, position, router, staker
  2. test cases to support both unit test and file test

Update

  1. remove Mint, Faucet for all GRC20 tokens
  2. no pool creation fee
  3. update minDeposit of ugnot to wrap

FYI

ignore git action failing, it should be run fine when we use gnolang/gno binary, not our own gno binary

@r3v4s r3v4s requested review from notJoon and mconcat May 15, 2024 12:36
@r3v4s r3v4s self-assigned this May 15, 2024
@r3v4s r3v4s mentioned this pull request May 15, 2024
Merged
@notJoon notJoon merged commit af59932 into main May 16, 2024
1 check failed
@notJoon notJoon deleted the GSW-1037-apply-emit-event-in-contract branch May 16, 2024 01:20
@dongwon8247 dongwon8247 mentioned this pull request May 22, 2024
Open
@michelleellen michelleellen mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notJoon notJoon notJoon approved these changes

@mconcat mconcat Awaiting requested review from mconcat

Assignees

@r3v4s r3v4s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r3v4s @notJoon