Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSW-1458 feat: governance #331

Merged
merged 45 commits into from
Sep 4, 2024
Merged

GSW-1458 feat: governance #331

merged 45 commits into from
Sep 4, 2024

Conversation

r3v4s
Copy link
Member

@r3v4s r3v4s commented Aug 26, 2024

feat

  1. xGNS
  • most likey grc20 token (but can not be transfered)
  • convert GNS to xGNS with ratio 1:1
  1. Governance Staker
  • stake xGNS
  • delegate / undelegate
  • collect reward (gns emission, protocol_fee distribution)
  • multi token support
  1. Governance
  • make / vote proposal
  • execute other contract's function
  • delegate cumulative
  • emergency halt

@r3v4s r3v4s self-assigned this Aug 26, 2024
@r3v4s r3v4s requested a review from notJoon August 26, 2024 10:42
@r3v4s r3v4s changed the title GSW-1509 feat: xGNS GSW-1458 feat: governance Aug 27, 2024
gov/staker/staker.gno Outdated Show resolved Hide resolved
@r3v4s
Copy link
Member Author

r3v4s commented Aug 27, 2024

@notJoon It's draft PR. Please do not commit anything.

@r3v4s r3v4s marked this pull request as ready for review August 30, 2024 07:32
notJoon
notJoon previously approved these changes Aug 30, 2024
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

dongwon8247
dongwon8247 previously approved these changes Aug 31, 2024
Copy link
Member

@dongwon8247 dongwon8247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments before merging this out

protocol_fee/protocol_fee.gno Outdated Show resolved Hide resolved
protocol_fee/protocol_fee.gno Outdated Show resolved Hide resolved
protocol_fee/protocol_fee.gno Outdated Show resolved Hide resolved
@r3v4s r3v4s dismissed stale reviews from dongwon8247 and notJoon via 2d9c649 September 1, 2024 12:24
notJoon
notJoon previously approved these changes Sep 2, 2024
Copy link
Member

@notJoon notJoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well 👍

@r3v4s r3v4s marked this pull request as draft September 2, 2024 11:49
@r3v4s
Copy link
Member Author

r3v4s commented Sep 2, 2024

changing to draft
WIP //

  1. Getter
  2. Partial Undelegation History

@r3v4s r3v4s marked this pull request as ready for review September 4, 2024 02:22
notJoon
notJoon previously approved these changes Sep 4, 2024
@r3v4s r3v4s requested a review from onlyhyde September 4, 2024 09:36
Copy link
Member

@onlyhyde onlyhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@r3v4s r3v4s merged commit 2d1ea9a into main Sep 4, 2024
@r3v4s r3v4s deleted the GSW-1458-governance branch September 4, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants