Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Airdrop Getters #19

Merged
merged 10 commits into from
Aug 26, 2024
Merged

feat: Airdrop Getters #19

merged 10 commits into from
Aug 26, 2024

Conversation

notJoon
Copy link
Member

@notJoon notJoon commented Aug 13, 2024 •
edited
Loading

Description

Added getter functions for airdrop. mostly checking state and claim related.

@r3v4s r3v4s mentioned this pull request Aug 13, 2024
Draft
@notJoon notJoon requested review from AkydA and r3v4s August 13, 2024 06:10
@notJoon notJoon self-assigned this Aug 13, 2024
@notJoon notJoon marked this pull request as ready for review August 13, 2024 07:05
r3v4s
r3v4s reviewed Aug 13, 2024
View reviewed changes
airdrop/getter.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Aug 13, 2024
View reviewed changes
airdrop/getter.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Aug 13, 2024
View reviewed changes
airdrop/getter.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Aug 13, 2024
View reviewed changes
airdrop/getter.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make getter func as pure

@notJoon notJoon requested a review from r3v4s August 14, 2024 02:20
r3v4s
r3v4s reviewed Aug 14, 2024
View reviewed changes
airdrop/airdrop.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Aug 14, 2024
View reviewed changes
airdrop/getter.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Aug 14, 2024
View reviewed changes
airdrop/getter_test.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s reviewed Aug 14, 2024
View reviewed changes
airdrop/utils.gno Outdated Show resolved Hide resolved
r3v4s
r3v4s requested changes Aug 14, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to resolve

@r3v4s r3v4s mentioned this pull request Aug 14, 2024
Merged
@notJoon notJoon requested a review from r3v4s August 21, 2024 02:30
r3v4s
r3v4s requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@r3v4s r3v4s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflict

@notJoon notJoon requested a review from r3v4s August 26, 2024 04:57
@notJoon notJoon merged commit 2ce5692 into main Aug 26, 2024
@notJoon notJoon deleted the airdrop-getter branch August 26, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkydA AkydA AkydA approved these changes

@r3v4s r3v4s r3v4s approved these changes

Assignees

@notJoon notJoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notJoon @AkydA @r3v4s