Skip to content
This repository has been archived by the owner on Aug 21, 2020. It is now read-only.

Commit

Permalink
Makefile: do not run wget as background process (fixes #10).
Browse files Browse the repository at this point in the history
By putting quotes around the URL, `wget` will not be started as
background process in the presence of ampersands `&` in the command.
See
https://superuser.com/questions/1011228/bash-script-not-waiting-for-wget-to-finish-download
 for details.

This avoids an ugly case, where an archive is extracted before the
download has finished.
  • Loading branch information
siko1056 committed Mar 6, 2018
1 parent 892e20b commit c35055b
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ OPENBLAS_VER = 0.2.20
$(SRC_CACHE)/openblas-$(OPENBLAS_VER).zip:
@echo -e "\n>>> Download OpenBLAS <<<\n"
cd $(SRC_CACHE) && wget -q \
https://github.com/xianyi/OpenBLAS/archive/v$(OPENBLAS_VER).zip \
"https://github.com/xianyi/OpenBLAS/archive/v$(OPENBLAS_VER).zip" \
&& mv v$(OPENBLAS_VER).zip $@

$(INSTALL_DIR)/lib/libopenblas$(_SONAME_SUFFIX).so: \
Expand Down Expand Up @@ -81,7 +81,7 @@ SUITESPARSE_LIBS = amd camd colamd ccolamd csparse cxsparse cholmod umfpack \
$(SRC_CACHE)/suitesparse-$(SUITESPARSE_VER).tar.gz:
@echo -e "\n>>> Download SuiteSparse <<<\n"
cd $(SRC_CACHE) && wget -q \
http://faculty.cse.tamu.edu/davis/SuiteSparse/SuiteSparse-$(SUITESPARSE_VER).tar.gz \
"http://faculty.cse.tamu.edu/davis/SuiteSparse/SuiteSparse-$(SUITESPARSE_VER).tar.gz" \
&& mv SuiteSparse-$(SUITESPARSE_VER).tar.gz $@

$(INSTALL_DIR)/lib/libsuitesparseconfig$(_SONAME_SUFFIX).so: \
Expand Down Expand Up @@ -136,7 +136,7 @@ QRUPDATE_CONFIG_FLAGS = \
$(SRC_CACHE)/qrupdate-$(QRUPDATE_VER).tar.gz:
@echo -e "\n>>> Download QRUPDATE <<<\n"
cd $(SRC_CACHE) && wget -q \
http://downloads.sourceforge.net/project/qrupdate/qrupdate/1.2/qrupdate-$(QRUPDATE_VER).tar.gz
"http://downloads.sourceforge.net/project/qrupdate/qrupdate/1.2/qrupdate-$(QRUPDATE_VER).tar.gz"

$(INSTALL_DIR)/lib/libqrupdate$(_SONAME_SUFFIX).so: \
$(SRC_CACHE)/qrupdate-$(QRUPDATE_VER).tar.gz \
Expand Down Expand Up @@ -168,7 +168,7 @@ ARPACK_VER = 3.5.0
$(SRC_CACHE)/arpack-$(ARPACK_VER).tar.gz:
@echo -e "\n>>> Download ARPACK <<<\n"
cd $(SRC_CACHE) && wget -q \
https://github.com/opencollab/arpack-ng/archive/$(ARPACK_VER).tar.gz \
"https://github.com/opencollab/arpack-ng/archive/$(ARPACK_VER).tar.gz" \
&& mv $(ARPACK_VER).tar.gz $@

$(INSTALL_DIR)/lib/libarpack$(_SONAME_SUFFIX).so: \
Expand Down Expand Up @@ -240,7 +240,7 @@ OCTAVE_CONFIG_FLAGS = \
$(SRC_CACHE)/octave-$(OCTAVE_VER).tar.gz:
@echo -e "\n>>> Download GNU Octave <<<\n"
cd $(SRC_CACHE) && wget -q \
https://ftp.gnu.org/gnu/octave/octave-$(OCTAVE_VER).tar.gz
"https://ftp.gnu.org/gnu/octave/octave-$(OCTAVE_VER).tar.gz"

$(INSTALL_DIR)/bin/octave: $(SRC_CACHE)/octave-$(OCTAVE_VER).tar.gz \
$(INSTALL_DIR)/lib/libopenblas$(_SONAME_SUFFIX).so \
Expand Down

0 comments on commit c35055b

Please sign in to comment.