-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oot-dev and pybombs-dev images #35
Open
igorauad
wants to merge
5
commits into
gnuradio:master
Choose a base branch
from
igorauad:dev_images
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the repository will contain different images, not only the images used on CI, rename de directory containing Dockerfile to docker/. Also, name all Dockerfiles with a .dockerfile extension and remove the unnecessary directories containing each of them.
igorauad
had a problem deploying
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Failure
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
had a problem deploying
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Failure
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 8, 2023 22:30 — with
GitHub Actions
Inactive
igorauad
had a problem deploying
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Failure
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
had a problem deploying
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Failure
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:24 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:25 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:25 — with
GitHub Actions
Inactive
igorauad
had a problem deploying
to
github-action-autobuild
March 9, 2023 01:25 — with
GitHub Actions
Failure
igorauad
had a problem deploying
to
github-action-autobuild
March 9, 2023 01:25 — with
GitHub Actions
Failure
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:25 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:26 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:26 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:26 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:26 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:26 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:26 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:27 — with
GitHub Actions
Inactive
igorauad
temporarily deployed
to
github-action-autobuild
March 9, 2023 01:27 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is based on gnuradio/gnuradio#6194. I've been maintaining the
igorfreire/gnuradio-oot-dev
image on DockerHub and using it for various things, like testing OOTs on CI (see the gr-dvbs2rx CI). So the idea is to migrate this image into thegnuradio/
namespace on DockerHub.Issue gnuradio/gnuradio#6194 mentions creating a dedicated repo for this, but I have the sense that a single repository handling all GR-related Docker images would work better. From a quick look, it seems this repository (gnuradio-docker) would be the appropriate place.
This PR changes the following:
docker/
directory. All files have the.dockerfile
extension and the CI builders are named asci-*.dockerfile
.oot-dev
image and extensive documentation adapted from https://github.com/igorauad/docker-gnuradio-oot-dev/blob/master/README.md.pybombs-dev
image based on theigorfreire/pybombs-dev
image proposed in Add workflow to test building changed recipes gr-etcetera#121. I recognize the pybombs-docker repo contains similar images and would be happy to adapt here based on them if you prefer.If you agree with the changes, the roadmap for the PR would be to:
gnuradio/
DockerHub account. They were tested in my account only.