Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kernel name with leading x character throws exception #59

Closed
stwunsch opened this issue Dec 20, 2015 · 6 comments
Closed

Kernel name with leading x character throws exception #59

stwunsch opened this issue Dec 20, 2015 · 6 comments

Comments

@stwunsch
Copy link
Contributor

Hi,

A kernel with the name volk_32f_x2_x_32f throws an exception during ctest. The problem is simply a leading x in the kernel name "x", which looks like the "x" of the input signiture.
If this is known and intended, just close the issue!

Greetings
Stefan

@stwunsch
Copy link
Contributor Author

I mean this exception in qa_utils.cc:376:

catch (boost::bad_lexical_cast& error) {
    std::cerr << "Error: unable to get function signature from kernel name" << std::endl;
    std::cerr << "  - " << name << std::endl;
    return false;
}

@n-west
Copy link
Member

n-west commented Dec 20, 2015

Hey Stefan, not intended but not something anyone has complained about. If the fix is as easy as I think it might be I can fix it, otherwise it's kind of a niche feature (especially the x case) that it might be a do not fix.

@douggeiger
Copy link
Contributor

I'm guessing this is the signature parsing code not knowing when it's parsing signatures (ala x2 or x3 to signify multiple inputs of the same type) vs. when it is getting to the name of the kernel. I'm not confident there is an unamiguous way for the parser to know this in advance - except to check if the second character is a digit or not - which basically just makes x[0-9]+ a special (not-allowed at the beginning of the name) vs. just x* being special.

n-west added a commit that referenced this issue Dec 21, 2015
@n-west
Copy link
Member

n-west commented Dec 21, 2015

Fixed

@n-west n-west closed this as completed Dec 21, 2015
n-west added a commit to n-west/volk that referenced this issue Dec 23, 2015
@michaelld
Copy link
Contributor

@ValZapod Let's take the discussion to this issue #326

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@michaelld @douggeiger @n-west @stwunsch and others