Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for rounding error in volk_32fc_s32f_magnitude_16i #713

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Allow for rounding error in volk_32fc_s32f_magnitude_16i #713

merged 1 commit into from
Dec 10, 2023

Conversation

argilo
Copy link
Member

@argilo argilo commented Dec 8, 2023

volk_32fc_s32f_magnitude_16i fails in i386 Debian CI and locally:

97: offset 33275 in1: 295 in2: 296 tolerance was: 0
97: volk_32fc_s32f_magnitude_16i: fail on arch a_avx2
97: offset 33275 in1: 295 in2: 296 tolerance was: 0
97: volk_32fc_s32f_magnitude_16i: fail on arch a_sse3
97: offset 33275 in1: 295 in2: 296 tolerance was: 0
97: volk_32fc_s32f_magnitude_16i: fail on arch a_sse
97: offset 33275 in1: 295 in2: 296 tolerance was: 0
97: volk_32fc_s32f_magnitude_16i: fail on arch u_avx2

As with #647, #704, and #712, this is due to floating-point calculations followed by rounding. I've increased the tolerance to 1 to allow for floating-point error in cases where the the fractional part of the magnitude is very close to 0.5.

@argilo
Allow for rounding error in volk_32fc_s32f_magnitude_16i
1828eae 
Signed-off-by: Clayton Smith <argilo@gmail.com>
@argilo argilo mentioned this pull request Dec 9, 2023
Open
jdemel
jdemel approved these changes Dec 10, 2023
View reviewed changes
Copy link
Contributor

@jdemel jdemel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdemel jdemel merged commit b89686f into gnuradio:main Dec 10, 2023
32 checks passed
@argilo argilo mentioned this pull request Dec 14, 2023
Merged
Alesha72003 pushed a commit to Alesha72003/volk that referenced this pull request May 15, 2024
@jdemel
Merge pull request gnuradio#713 from argilo/magnitude-tol
4747b98 
Allow for rounding error in volk_32fc_s32f_magnitude_16i
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdemel jdemel jdemel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@argilo @jdemel