Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
volk_32fc_x2_conjugate_dot_prod_32fc
fails in i386 Debian CI and locally. Only thea_sse_32
protokernel is broken:I had a look over the code, and it appears the problem is that inline assembler writes to
input
,taps
, and*result
without telling the compiler about that. I made a few attempts at fixing it, but I'm not sure whether it's worth saving this ugly code. I doubt this protokernel sees much use, since it is only available on 32-bit systems, and many newer protokernels are now available on 32-bit x86.It appears
volk_32fc_x2_dot_prod_32fc_a_sse_64
had a similar bug, as it was commented out in 2012 and remains commented out today:gnuradio/gnuradio@43224ac
I've removed that protokernel here as well. After this change, there are no more
sse_32
protokernels left in VOLK.