Make Inspector's shortcuts available globally again #42
Conversation
|
@gcasa still waiting for review. |
Hey. Sorry I have been working on a new contract. So it's been busy lately. I vaguely remember taking this change out for some reason. |
|
@gcasa it's not clear to me if you have any objections merging this PR. Could you please make a review? |
| /* | ||
| NSApplication override to make Inspector's shortcuts available globally | ||
| */ | ||
| - (void) sendEvent: (NSEvent *)theEvent |
There was a problem hiding this comment.
This change concerns me because it is not the default behavior in other applications. Why do the key equivalents of every inspector need to be handled GLOBALLY? Can you explain what bug this fixes for you, what is the use-case you're attempting to address?
There was a problem hiding this comment.
The other issue here is that there was a reason I moved AWAY from making Gorm use an NSApplication subclass.
There was a problem hiding this comment.
This change concerns me because it is not the default behavior in other applications.
Any application can be subclassed from NSApplication and redefine default shortcuts handling. I see no problem here.
Why do the key equivalents of every inspector need to be handled GLOBALLY? Can you explain what bug this fixes for you, what is the use-case you're attempting to address?
There's no bug it's usability enhancement. For example, if user wants to see what connections selected object has (whithout focus switch) it's handy to press shortcut whithout moving mouse and selecting "Connections" sections of Inpector.
There was a problem hiding this comment.
The other issue here is that there was a reason I moved AWAY from making Gorm use an NSApplication subclass.
Could you please explain that reason? It might be useful for development practice.
It was broken after refactoring some times ago.