tests: Test that we can throw and catch the same exception multiple times sequentially. #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
davidchisnall
force-pushed
the
test-objcxx-interop-twice
branch
from
b0787e1 to
28d0445
Compare
|
Rebased on master and with the fix from #152 added. |
|
Nice, thank you! |
ngrewe
approved these changes
Feb 7, 2021
…imes sequentially. This originally came up as an issue with libc++abi support (#152), but is not specific to that ABI.
As discussed in #152, use the function defined in the Itanium C++ ABI to check whether the thrown exception is the current caught C++ exception and needs rethrowing via `__cxa_rethrow()`.
triplef
force-pushed
the
test-objcxx-interop-twice
branch
from
cf20045 to
7dcd112
Compare
|
I rebased to fix a small merge conflict. I think we can merge this @davidchisnall? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originally came up as an issue with libc++abi support (#152), but is not specific to that ABI.
It was extracted from the
libc++branch as to unblock merging #152.The test currently fails, but the solution was discussed in #152 (comment).