CMakeLists.txt: fixed mistyped name tsl-robin-map_FOUND variable.
#274
Conversation
This change let package maintainers use `tsl-robin-map_DIR` cmake parameter with path set to cloned and built robin-map repo.
|
Great catch, thanks! I wonder if we should do a 2.2.1 to incorporate this. I completely missed it in review. |
|
FYI: Part of the motivation for this change (modulo the bug that you've fixed) is that package maintainers should be able to use their system-installed version, they shouldn't need to set |
Not exactly. I mean cloning robin-map github repo, configure, build and after that specify -Dtsl-robin-map_DIR=<directory/where/robin-map/built>. I don't need to install robin-map in that case. |
Yes, make a new tag please! |
The build system should do that for you through |
|
I presume the use case here is packaging systems that don’t want to add a package for robin map as a build dep, but also don’t allow package builders to connect to the network during the build phase (an entirely sensible security policy). It’s worth noting that FetchContent has some existing support for this. There are a couple of CMake variables that you can set to tell it not to try downloading and where you’ve downloaded it to. It will then work with the existing path. |
|
That makes sense, thanks for the clarification! |
This change let package maintainers use
tsl-robin-map_DIRcmake parameter with path set to cloned and built robin-map repo.