Fix another leak

gnustep · Nov 22, 2024 · 021812f · 021812f
1 parent 99bb50d
commit 021812f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -4,6 +4,8 @@
 	than recursively ... reduces the depth of recursion to the depth of
 	nesting children rather than the number of children, avoiding stack
 	overflow  for large projects.
+	* Source/GSHTTPURLHandle.m: Fix leak of connection description strings
+	when reconnecting an existing handle.
 
 2024-11-21 Richard Frith-Macdonald <rfm@gnu.org>
 

diff --git a/Source/GSHTTPURLHandle.m b/Source/GSHTTPURLHandle.m
@@ -1173,12 +1173,12 @@ - (void) bgdConnect: (NSNotification*)notification
       return;
     }
 
-  in = [[NSString alloc] initWithFormat: @"(%@:%@ <-- %@:%@)",
+  ASSIGN(in, [NSString stringWithFormat: @"(%@:%@ <-- %@:%@)",
     [sock socketLocalAddress], [sock socketLocalService],
-    [sock socketAddress], [sock socketService]];
-  out = [[NSString alloc] initWithFormat: @"(%@:%@ --> %@:%@)",
+    [sock socketAddress], [sock socketService]]);
+  ASSIGN(out, [NSString stringWithFormat: @"(%@:%@ --> %@:%@)",
     [sock socketLocalAddress], [sock socketLocalService],
-    [sock socketAddress], [sock socketService]];
+    [sock socketAddress], [sock socketService]]);
 
   if (debug)
     {