patch to improve thread startup by Larry Campbell

gnustep · Jan 29, 2024 · 41d948b · 41d948b
1 parent 1cf38de
commit 41d948b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,7 +1,12 @@
+2024-01-08 Richard Frith-Macdonald <rfm@gnu.org>
+
+	* Source/NSOperation.m: patch for issue #366 by Larry Campbell.
+
 2024-01-08 Richard Frith-Macdonald <rfm@gnu.org>
 
 	* Source/NSJSONSerialization.m: Fix for issue #365 ... don't try to
 	create a string ending with the first half of a unicode surrogate pair.
+
 2024-01-08 Richard Frith-Macdonald <rfm@gnu.org>
 
 	* Source/NSNotificationCenter.m: fix for memory leak should keep the

diff --git a/Source/NSOperation.m b/Source/NSOperation.m
@@ -1112,17 +1112,13 @@ - (void) _execute
 	}
       else
 	{
-	  NSUInteger	pending;
-
 	  [internal->cond lock];
-	  pending = [internal->starting count];
 	  [internal->starting addObject: op];
 
 	  /* Create a new thread if all existing threads are busy and
 	   * we haven't reached the pool limit.
 	   */
-	  if (0 == internal->threadCount
-	    || (pending > 0 && internal->threadCount < max))
+	  if (internal->threadCount < max)
 	    {
 	      internal->threadCount++;
 	      NS_DURING