Skip all NSURL* test cases using GSInetServerStream on Windows

[hmelder]

No description provided.

[hmelder]

Btw I think we should deprecate GSServerStream. It is not used anywhere in the code base and only exposed as a category in GNUstep additions. The implementation is too complicated for what it does.

[hmelder]

Is it ok to merge @rfm ?

[rfm]

I'm not sure of the rationale here.
While GSServerStream is (so far as i can see) only used in NSSetServices in the base library and in a few testcases, I wonder if it's really not useful / too complicated? I think it would be fine to deprecate and then replace it in those places (and remove it from the additions api) if it's easy.
But, if it's simple to replace, why not do that rather than removing the tests?

[hmelder]

But, if it's simple to replace, why not do that rather than removing the tests?

The unit tests implement multiple test server based on GSServerStream. Rewriting all of them would be a major undertaking. I think we should temporarily disable them.

[triplef]

#266 has some more info about the issues with GSServerStream on Windows.

For now it would be great if we can mark the tests using it as hopeful on Windows (as this PR does). This will allow us to disable allow-test-failures on the Windows CI targets, so that possible future changes breaking Windows builds will actually fail those builds.

[rfm]

Marking the tests as hopeful seems fine to me.

[hmelder]

Marking the tests as hopeful seems fine to me.

This was my original plan, but I ran into some issues back then. I can look into this and update the PR.

[hmelder]

Forgot the semicolons. Wrote to much golang :)

[hmelder]

Done! We have no test failures in Windows MinGW GCC x86_64 and Windows MSVC x86_64. There is still an unrelated test failure on 32-bit machines. Ready to check @rfm

[triplef]

Awesome, great job @hmelder! 🎉

I think this should be removed then as well (for both 64-bit Windows targets):

libs-base/.github/workflows/main.yml

Line 67 in 996a5b8

allow-test-failures: true

[hmelder]

@rfm ready to review

[RoyalStewart90]

Hi @hmelder, very sorry to be this late to the party, earlier this year I was poking around the IPv6 functionality and made some changes to my company's branch of Master. In your experience, what was the issue with GSInetServerStream? I had encountered a few issues of formatting IPv6 address with brackets related to GSStreams. The biggest issue I ran into was memory allocation of IP addresses. I'm hoping at some point we can get this issue fixed and re-enable more connection tests.

[hmelder]

@RoyalStewart90 see #266

I think it was an issue with the asynchronous event handling on Windows. I would have to go into the issue as this was about a year ago :)